Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix param to the star macro #409

Closed
camerondavison opened this issue Sep 3, 2021 · 2 comments · Fixed by #436
Closed

Add prefix param to the star macro #409

camerondavison opened this issue Sep 3, 2021 · 2 comments · Fixed by #436
Labels
duplicate enhancement New feature or request

Comments

@camerondavison
Copy link

Describe the feature

Sometimes when you want to include all of the columns of another table it can be useful to prefix them all as well with something. So that if I include a pets table the table may have the columns name,age and you may want to join it to a people table that also hase name,age and you want to end up with a result that is name,age,pet_name,pet_age or something like that.

Describe alternatives you've considered

Alternatively you have to reimplement the star macro by iterating all the columns and adding the prefix.

Are you interested in contributing this feature?

I created a patch of the star command, to work with my postgres db, so I would be willing to contribute it. I would need help knowing how to test it on multiple databases using the code base.

@camerondavison camerondavison added enhancement New feature or request triage labels Sep 3, 2021
@joellabes
Copy link
Contributor

I think that this is a dupe of #436 so I'm going to close it out! Let me know if that's not the case.

@joellabes joellabes added duplicate and removed triage labels Nov 9, 2021
@joellabes joellabes reopened this Nov 10, 2021
@joellabes joellabes linked a pull request Nov 10, 2021 that will close this issue
12 tasks
@joellabes
Copy link
Contributor

Was a bit premature in closing this! Haven't actually merged the code yet 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants