Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2061] [Bug] Query tags not unset for view materialization #456

Closed
2 tasks done
NiallRees opened this issue Feb 8, 2023 · 1 comment · Fixed by #457
Closed
2 tasks done

[CT-2061] [Bug] Query tags not unset for view materialization #456

NiallRees opened this issue Feb 8, 2023 · 1 comment · Fixed by #457
Labels
type:bug Something isn't working

Comments

@NiallRees
Copy link
Contributor

Is this a new bug in dbt-snowflake?

  • I believe this is a new bug in dbt-snowflake
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Query tags not unset for view materialization

Expected Behavior

Query tags are unset for view materialization

Steps To Reproduce

Set a query tag for a view, watch it not be unset

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-snowflake:

Additional Context

No response

@NiallRees NiallRees added type:bug Something isn't working triage:product labels Feb 8, 2023
@github-actions github-actions bot changed the title [Bug] Query tags not unset for view materialization [CT-2061] [Bug] Query tags not unset for view materialization Feb 8, 2023
@dbeatty10
Copy link
Contributor

Thanks for submitting a PR for this @NiallRees !

Since it was clear from your PR why the query tag wasn't being unset, I didn't go through the extra effort of reproducing this. A member of our Adapters team will review your PR when they are able.

A left some small comments on the PR, one for you, and one for the PR reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants