-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-1749] [Feature] Let Snowpark telemetry know that dbt is creating the sproc #374
Comments
Do we have to call |
agreed we should move it if possible to below the import instead of in user code I don't see any reason we couldn't/shouldn't do this, would definitely check w/ @jtcohen6 to be sure |
@dataders can you please expand on the alternate solution linked? Are you suggesting dbt python models will be able to add a specific query tag, say "snowpark_python" ? |
@sfc-gh-ripu If I understand right, we're awaiting confirmation from folks on your side that it's possible to do something similar to @dataders My hesitation with the |
@dataders I confirmed with Snowpark team, the |
@sfc-gh-ripu amazing! just opened up #383 as a draft. @ChenyuLInx @colin-rogers-dbt wanna take a look? |
Is this your first time submitting a feature request?
Describe the feature
Snowflake is requesting that the below line of code be added to the body of user-created python functions used to create python UDFs on behalf of users behind the scenes and have
PartnerName_ToolName="dbt"
Below is where our template of sproc creation is implemented. It seems the implementation would be to somehow modify the function definition in
compiled_code
to also include thesys._xoptions
call?dbt-snowflake/dbt/adapters/snowflake/impl.py
Lines 199 to 210 in e18c501
This is an example provide by the Snowflake team
Describe alternatives you've considered
We do nothing
This is one idea
We add a session parameter to connection creation?
Not sure if this would be helpful for the Snowpark team, that wants to track consumption...
https://github.com/dbt-labs/dbt-snowflake/blob/main/dbt/adapters/snowflake/connections.py#L284-L285
Who will this benefit?
No response
Are you interested in contributing this feature?
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: