Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurations for null value handing in metrics #142

Closed
Tracked by #140
QMalcolm opened this issue Sep 7, 2023 · 0 comments · Fixed by #159
Closed
Tracked by #140

Add configurations for null value handing in metrics #142

QMalcolm opened this issue Sep 7, 2023 · 0 comments · Fixed by #159
Assignees
Labels
Backport 0.2.latest Fix should be backported to 0.2.latest enhancement New feature or request

Comments

@QMalcolm
Copy link
Collaborator

QMalcolm commented Sep 7, 2023

A bug was raised in MetricFlow recently (dbt-labs/metricflow#764) outlining how null values are not handled properly in some cases. The proposed solution (dbt-labs/metricflow#759) requires changes to the MetricInputMeasure protocol used by MetricTypeParams protocol on Metric protocol. Specifically two new optional properties need to be added

  • join_to_timespine which should have a boolean value
  • fill_nulls_with which should optionally have a integer value

In the pydantic object implementations

  • join_to_timespine should default to false if not specified during parsing / deserialization
  • fill_nulls_with should default to None if not specified during parsing / deserialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport 0.2.latest Fix should be backported to 0.2.latest enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants