[CT-3027] [Bug] Create test cases for each materialization type that end in a SQL comment (-- like this)

[dbeatty10]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

We don't have functional tests for models ending with a SQL comment (-- like this comment), which has led to bug reports like #6781 and dbt-labs/dbt-bigquery#896.

Snapshots were covered within #6780, but there are other materialization types left undone.

Expected Behavior

As discussed here, we should add a comment to the end of models in integration tests for each of our materialization types + singular and generic tests to catch any regressions in the future.

Steps To Reproduce

See the steps to reproduce in the issues linked above.

Implementations

Implementation in adapters

Preview Give feedback

1. dbt-bigquery: [ADAP-846] [Bug] Inline comments (--) on the last line of an incremental model (partition replacement) results in invalid SQL statement dbt-bigquery#896
2. dbt-postgres
3. dbt-redshift
4. dbt-snowflake
5. dbt-spark

Implementation example

#6780 provides an example of how to test this for snapshots. We'd just need to do something similar for other materialization types.

Just add something like this to the bottom of a simple materialization of each type:

dbt-core/tests/functional/simple_snapshot/test_comment_ending_snapshot.py

Line 17 in 4d3c6d9

-- Test comment to prevent recurrence of https://github.com/dbt-labs/dbt-core/issues/6781

[github-actions]

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.