Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2964] Backport #7630 to 1.3 and 1.4 #8372

Closed
peterallenwebb opened this issue Aug 11, 2023 · 1 comment
Closed

[CT-2964] Backport #7630 to 1.3 and 1.4 #8372

peterallenwebb opened this issue Aug 11, 2023 · 1 comment
Assignees

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Aug 11, 2023

The security fix made for #7630 in 1.5 and 1.6 to exclude some profile fields from Jinja rendering now needs to be backported to 1.3 and 1.4.

@github-actions github-actions bot changed the title Backport #7630 to 1.3 and 1.4 [CT-2964] Backport #7630 to 1.3 and 1.4 Aug 11, 2023
@peterallenwebb peterallenwebb self-assigned this Aug 11, 2023
@peterallenwebb
Copy link
Contributor Author

We have decided not to include unit tests for the 1.3 and 1.4 backports of this fix. The reason is that the automated tests written for 1.5+ do not work with the older logging infrastructure in 1.3 and 1.4, combined with the fact that regressions of this functionality are unlikely in 1.3 and 1.4. The regressions are unlikely both because these versions are rarely modified and also because the code in question is relatively self contained and itself in a rarely modified module.

I did verify the fixes both in the 1.3 and 1.4 patch branches by manually testing that the unwanted error messages appeared before the fix, but not after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant