Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1800] Make logging of meta in node_info more flexible. #6581

Closed
gshank opened this issue Jan 11, 2023 · 1 comment
Closed

[CT-1800] Make logging of meta in node_info more flexible. #6581

gshank opened this issue Jan 11, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@gshank
Copy link
Contributor

gshank commented Jan 11, 2023 •
edited
Loading

In #6216 we added the "meta" dictionary to the node_info that is included on logging events. Since the meta field in the protobuf message NodeInfo was defined as a string/string map, we had to force all of the keys to strings. We should try to make this more flexible, either by using a protobuf struct or a map of string to Any.
@github-actions github-actions bot changed the title Make logging of meta in node_info more flexible. [CT-1800] Make logging of meta in node_info more flexible. Jan 11, 2023
@jtcohen6 jtcohen6 mentioned this issue Feb 27, 2023
Closed
@jtcohen6
Copy link
Contributor

Closing as a duplicate of #6832

@jtcohen6 jtcohen6 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2023
@jtcohen6 jtcohen6 added duplicate This issue or pull request already exists Team:Language labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gshank @jtcohen6