Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1593] [Bug] Update core/dbt/README.md to match current situation #6368

Closed
2 tasks done
yoiki opened this issue Dec 2, 2022 · 1 comment · Fixed by #6371
Closed
2 tasks done

[CT-1593] [Bug] Update core/dbt/README.md to match current situation #6368

yoiki opened this issue Dec 2, 2022 · 1 comment · Fixed by #6371
Labels
bug Something isn't working

Comments

@yoiki
Copy link
Contributor

yoiki commented Dec 2, 2022

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

There are several omissions in core/dbt/README.md . constants.py, selected_resources.py, etc. are not listed.

Expected Behavior

List some file name under ## The following are individual files in this directory.

  • constants.py
  • selected_resources.py

Add some dir name under ## The subdirectories will be documented in a README in the subdirectory

  • contracts
  • parser
  • tests

It may be a good idea to sort this list in abc order to improve readability.

Steps To Reproduce

Please check core/dbt/README.md

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response

@yoiki yoiki added bug Something isn't working triage labels Dec 2, 2022
@github-actions github-actions bot changed the title [Bug] Update core/dbt/README.md to match current situation [CT-1593] [Bug] Update core/dbt/README.md to match current situation Dec 2, 2022
@dbeatty10 dbeatty10 self-assigned this Dec 2, 2022
@dbeatty10
Copy link
Contributor

Thanks for noticing and reaching out @yoiki !

I created #6371 to incorporate your suggestions.

@dbeatty10 dbeatty10 removed the triage label Dec 2, 2022
@dbeatty10 dbeatty10 removed their assignment Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants