Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-17] [Bug] dbt deps doesn't show which packages are installing in the logs #4461

Closed
1 task done
sungchun12 opened this issue Dec 8, 2021 · 2 comments · Fixed by #4482
Closed
1 task done

[CORE-17] [Bug] dbt deps doesn't show which packages are installing in the logs #4461

sungchun12 opened this issue Dec 8, 2021 · 2 comments · Fixed by #4482
Assignees
Labels
bug Something isn't working logging regression
Milestone

Comments

@sungchun12
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When I run dbt deps using version 1.0.0, I don't see which packages are installing corresponding to their version.

image

Expected Behavior

I should see something like the below.

image

Steps To Reproduce

  1. Setup a dbt project in cloud or local pc using v1.0.0
  2. Run dbt deps
  3. View output without packages corresponding to versions

Relevant log output

See screenshots above

Environment

- OS: ???
- Python: ???
- dbt: 1.0.0(latest)

dbt Cloud in use

What database are you using dbt with?

snowflake

Additional Context

No response

@sungchun12 sungchun12 added bug Something isn't working triage labels Dec 8, 2021
@sungchun12
Copy link
Contributor Author

sungchun12 commented Dec 8, 2021

This was caused by the new structured logging implementation missing the package name in the terminal output: here

It should be a simple fix at line 66: fire_event(DepsStartPackageInstall(package=package))

for package in final_deps:
    package_name = package.name
    source_type = package.source_type()
    version = package.get_version()
    fire_event(DepsStartPackageInstall(package=package))
    package.install(self.config, renderer)
    fire_event(DepsInstallInfo(version_name=package.nice_version_name()))
    if source_type == 'hub':
        version_latest = package.get_version_latest()

image

@jtcohen6
Copy link
Contributor

jtcohen6 commented Dec 9, 2021

@sungchun12 Nice catch! Thanks for raising.

@nathaniel-may Let's definitely add this as a high-priority TODO in our cleanup. I'd like to include this in a v1.0.1 release.

@jtcohen6 jtcohen6 added this to the v1.0.1 milestone Dec 10, 2021
@leahwicz leahwicz changed the title [Bug] dbt deps doesn't show which packages are installing in the logs [CORE-17] [Bug] dbt deps doesn't show which packages are installing in the logs Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants