Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up types.py for logging #4329

Closed
emmyoop opened this issue Nov 23, 2021 · 2 comments · Fixed by #4338
Closed

Clean up types.py for logging #4329

emmyoop opened this issue Nov 23, 2021 · 2 comments · Fixed by #4338
Assignees
@McKnight-42

Comments

@emmyoop
Copy link
Member

emmyoop commented Nov 23, 2021 •
edited
Loading

validate code values are unique for each event in core/dbt/events/types.py
- ex: E001 occurs twice

validate event is called only once in dump_callable
@emmyoop emmyoop added bug Something isn't working triage and removed bug Something isn't working triage labels Nov 23, 2021
@nathaniel-may nathaniel-may mentioned this issue Nov 23, 2021
Merged
4 tasks
@nathaniel-may
Copy link
Contributor

The tests that catch duplicate error codes were missed when we closed #4268 in favor of #4319

@McKnight-42 McKnight-42 mentioned this issue Nov 24, 2021
Merged
4 tasks
@McKnight-42
Copy link
Contributor

fixed with PR #4338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@McKnight-42 McKnight-42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mc knight 42/test event codes dbt-labs/dbt-core
3 participants
@emmyoop @nathaniel-may @McKnight-42