Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Simplify Flags #3973

Closed
nathaniel-may opened this issue Sep 29, 2021 · 4 comments
Closed

Further Simplify Flags #3973

nathaniel-may opened this issue Sep 29, 2021 · 4 comments
Labels
enhancement New feature or request stale Issues that have gone stale tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@nathaniel-may
Copy link
Contributor

Describe the feature

When adding a new flag, there are many places you must put the name of your flag in a very boiler platey fashion. Since adding and removing new flags is a very common user interface change that we want to get right, I would like to slightly rearrange the flow of flags so that you define the information once, and the rest of the code references that definition to set all the appropriate factors.

Describe alternatives you've considered

We could also just not do this, because the boiler plate isn't really that bad.

Additional context

You have to remember to put in all the argparse-specific parameters, defaults, and global values which are all defined in different places.

PR#3839 made huge improvements to the flag system already.

Who will this benefit?

dbt contributors and developers.

@nathaniel-may nathaniel-may added enhancement New feature or request triage tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Sep 29, 2021
@jtcohen6 jtcohen6 removed the triage label Sep 29, 2021
@gshank
Copy link
Contributor

gshank commented Oct 4, 2021

I suspect that we're going to see some changes in flag handling with the new server work. Not sure where we'll end up on that, so we might wait until we see the requirements there to address this.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Apr 3, 2022
@nathaniel-may nathaniel-may removed the stale Issues that have gone stale label Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Oct 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers.

@github-actions github-actions bot closed this as completed Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issues that have gone stale tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

3 participants