Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type hints in core/dbt/task/clean.py #10616

Closed
1 task done
QMalcolm opened this issue Aug 27, 2024 · 0 comments · Fixed by #10617
Closed
1 task done

Add missing type hints in core/dbt/task/clean.py #10616

QMalcolm opened this issue Aug 27, 2024 · 0 comments · Fixed by #10617
Assignees

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

We're putting some effort into improving our typing. There are two type errors in core/dbt/task/clean.py, we should fix them.

core/dbt/task/clean.py:19: error: Function is missing a return type annotation  [no-untyped-def]
core/dbt/task/clean.py:19: note: Use "-> None" if function does not return a value
core/dbt/task/clean.py:49: error: Call to untyped function "warn" in typed context  [no-untyped-call]

Acceptance criteria

Fix the typing issues

Suggested Tests

N/A

Impact to Other Teams

None

Will backports be required?

No

Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant