You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fine folks at BigQuery have been releasing a lot of solid SQL-standard syntax of late, which means a lucky contributor gets to delete a bunch of code.
The most obvious candidates to me are create schema and drop schema, which no longer need to be python methods—in fact, they no longer need to be bigquery__ macros at all, since the default implementations will do just fine.
Good time to revisit this @jtcohen6 or should we hold on this for a few more weeks? I assume you are just migrating issues over from the original repo.
@coapacetic We could give this another go. Last time, we ran into an issue with the integration tests... I don't imagine that's been entirely resolved, but we did simplify the test scaffolding slightly when we moved it over into this repo, so maybe we'd have better luck this time.
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.
Describe the feature
The fine folks at BigQuery have been releasing a lot of solid SQL-standard syntax of late, which means a lucky contributor gets to delete a bunch of code.
The most obvious candidates to me are
create schema
anddrop schema
, which no longer need to be python methods—in fact, they no longer need to bebigquery__
macros at all, since the default implementations will do just fine.https://github.com/fishtown-analytics/dbt/blob/7ec5c122e17ab7e1a5dd1e1cab36527159564a0f/plugins/bigquery/dbt/include/bigquery/macros/adapters.sql#L72-L78
Less pressing, still promising:
alter table add columns
.https://github.com/fishtown-analytics/dbt/blob/7ec5c122e17ab7e1a5dd1e1cab36527159564a0f/plugins/bigquery/dbt/adapters/bigquery/impl.py#L704
I'm sure there are more such opportunities!
When has there ever been a better first issue?
The text was updated successfully, but these errors were encountered: