From 0da625cfab1f3c39e8e4789caa8ad079a2a0df89 Mon Sep 17 00:00:00 2001
From: David Rapan <david@rapan.cz>
Date: Mon, 29 Jul 2024 15:26:55 +0200
Subject: [PATCH] feat: Add SG0XXP3 Battery Shutdown-Restart-Low

---
 .../inverter_definitions/deye_2mppt.yaml      |  15 ---
 .../inverter_definitions/deye_4mppt.yaml      |  17 +--
 .../inverter_definitions/deye_sg01hp3.yaml    | 121 ++++++++++++++++++
 .../inverter_definitions/deye_sg04lp3.yaml    | 121 ++++++++++++++++++
 4 files changed, 243 insertions(+), 31 deletions(-)

diff --git a/custom_components/solarman/inverter_definitions/deye_2mppt.yaml b/custom_components/solarman/inverter_definitions/deye_2mppt.yaml
index b56764ab..4d77eafc 100644
--- a/custom_components/solarman/inverter_definitions/deye_2mppt.yaml
+++ b/custom_components/solarman/inverter_definitions/deye_2mppt.yaml
@@ -215,7 +215,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x002B]
-        isstr: true
         lookup:
           - key: 0
             value: "OFF"
@@ -230,7 +229,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x002E]
-        isstr: true
         lookup:
           - key: 0
             value: "Disabled"
@@ -245,7 +243,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x0031]
-        isstr: true
         lookup:
           - key: 0
             value: "Disabled"
@@ -262,7 +259,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x003B]
-        isstr: true
         lookup:
           - key: 0
             value: "Standby"
@@ -310,7 +306,6 @@ parameters:
         scale: 1
         rule: 5
         registers: [0x0003, 0x0004, 0x0005, 0x0006, 0x0007]
-        isstr: true
 
       - name: "Hardware Version"
         class: ""
@@ -329,7 +324,6 @@ parameters:
         rule: 7
         registers: [0x000D]
         icon: "mdi:map-marker"
-        isstr: true
 
       - name: "AC Version. Number"
         class: ""
@@ -339,7 +333,6 @@ parameters:
         rule: 7
         registers: [0x000E]
         icon: "mdi:map-marker"
-        isstr: true
 
       - name: "Rated Power"
         class: "energy"
@@ -359,7 +352,6 @@ parameters:
         rule: 7
         registers: [0x0012]
         icon: "mdi:wrench"
-        isstr: true
 
       - name: "Start-up Self-checking Time "
         class: ""
@@ -378,7 +370,6 @@ parameters:
         rule: 8
         registers: [0x0016, 0x0017, 0x0018]
         icon: "mdi:clock-time-three-outline"
-        isstr: true
 
       - name: "Device Rated Power"
         class: ""
@@ -387,7 +378,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x0008]
-        isstr: true
         lookup:
           - key: 1
             value: "single-phase"
@@ -411,7 +401,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x002F]
-        isstr: true
         lookup:
           - key: 0
             value: "Disabled"
@@ -435,7 +424,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x0036]
-        isstr: true
         lookup:
           - key: 0
             value: "Disabled"
@@ -453,7 +441,6 @@ parameters:
         rule: 3
         registers: [0x0067, 0x0068, 0x0069, 0x006a]
         icon: "mdi:alert-octagon-outline"
-        isstr: true
         lookup:
           - key: 0
             value: "None"
@@ -470,7 +457,6 @@ parameters:
         rule: 1
         registers: [0x0065, 0x0066]
         icon: "mdi:information-slab-circle-outline"
-        isstr: true
         lookup:
           - key: 0
             value: "None"
@@ -501,7 +487,6 @@ parameters:
         rule: 6
         registers: [0x0075, 0x0076]
         icon: "mdi:message-alert-outline"
-        isstr: true
         lookup:
           - key: 0
             value: "None"
diff --git a/custom_components/solarman/inverter_definitions/deye_4mppt.yaml b/custom_components/solarman/inverter_definitions/deye_4mppt.yaml
index edba88e5..28fc3434 100644
--- a/custom_components/solarman/inverter_definitions/deye_4mppt.yaml
+++ b/custom_components/solarman/inverter_definitions/deye_4mppt.yaml
@@ -260,7 +260,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x002B]
-        isstr: true
         lookup:
           - key: 0
             value: "OFF"
@@ -275,7 +274,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x002E]
-        isstr: true
         lookup:
           - key: 0
             value: "Disabled"
@@ -290,7 +288,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x0031]
-        isstr: true
         lookup:
           - key: 0
             value: "Disabled"
@@ -308,7 +305,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x003B]
-        isstr: true
         lookup:
           - key: 0
             value: "Stand-by"
@@ -359,7 +355,6 @@ parameters:
         scale: 1
         rule: 5
         registers: [0x0003, 0x0004, 0x0005, 0x0006, 0x0007]
-        isstr: true
         
       - name: "Hardware Version"
         class: ""
@@ -378,7 +373,6 @@ parameters:
         rule: 7
         registers: [0x000D]
         icon: "mdi:map-marker"
-        isstr: true
 
       - name: "AC Version. Number"
         class: ""
@@ -388,7 +382,6 @@ parameters:
         rule: 7
         registers: [0x000E]
         icon: "mdi:map-marker"
-        isstr: true
 
       - name: "Rated Power"
         realtime:
@@ -408,7 +401,6 @@ parameters:
         rule: 7
         registers: [0x0012]
         icon: "mdi:wrench"
-        isstr: true
         
       - name: "Start-up Self-checking Time "
         class: ""
@@ -427,7 +419,6 @@ parameters:
         rule: 8
         registers: [0x0016, 0x0017, 0x0018]
         icon: "mdi:clock-time-three-outline"
-        isstr: true
 
       - name: "Device Rated Power"
         class: ""
@@ -436,7 +427,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x0008]
-        isstr: true
         lookup:
           - key: 1
             value: "single-phase"
@@ -461,7 +451,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x002F]
-        isstr: true
         lookup:
           - key: 0
             value: "Disabled"
@@ -487,7 +476,6 @@ parameters:
         scale: 1
         rule: 1
         registers: [0x0036]
-        isstr: true
         lookup:
           - key: 0
             value: "Disabled"
@@ -495,7 +483,7 @@ parameters:
             value: "Enabled"
         icon: "mdi:factory"
         
- - group: Alert
+  - group: Alert
     items:
       - name: "Fault information"
         class: ""
@@ -505,7 +493,6 @@ parameters:
         rule: 3
         registers: [0x0067, 0x0068, 0x0069, 0x006a]
         icon: "mdi:alert-octagon-outline"
-        isstr: true
         lookup:
           - key: 0
             value: "None"
@@ -522,7 +509,6 @@ parameters:
         rule: 1
         registers: [0x0065, 0x0066]
         icon: "mdi:information-slab-circle-outline"
-        isstr: true
         lookup:
           - key: 0
             value: "None"
@@ -553,7 +539,6 @@ parameters:
         rule: 6
         registers: [0x0075, 0x0076]
         icon: "mdi:message-alert-outline"
-        isstr: true
         lookup:
           - key: 0
             value: "None"
diff --git a/custom_components/solarman/inverter_definitions/deye_sg01hp3.yaml b/custom_components/solarman/inverter_definitions/deye_sg01hp3.yaml
index 868e1d75..0fdb5bce 100644
--- a/custom_components/solarman/inverter_definitions/deye_sg01hp3.yaml
+++ b/custom_components/solarman/inverter_definitions/deye_sg01hp3.yaml
@@ -374,6 +374,127 @@ parameters:
           - key: 0x0002
             value: No Battery
 
+      - name: Battery Resistance
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "mΩ"
+        scale: 1
+        rule: 1
+        registers: [0x0071]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 6000
+
+      - name: Battery Charging efficiency
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "%"
+        scale: 0.1
+        rule: 1
+        registers: [0x0072]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 100
+
+      - name: Battery Shutdown SOC
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "%"
+        scale: 1
+        rule: 1
+        registers: [0x0073]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 100
+
+      - name: Battery Restart SOC
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "%"
+        scale: 1
+        rule: 1
+        registers: [0x0074]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 100
+
+      - name: Battery Low SOC
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "%"
+        scale: 1
+        rule: 1
+        registers: [0x0075]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 100
+
+      - name: Battery Shutdown Voltage
+        update_interval: 300
+        class: "voltage"
+        state_class: measurement
+        uom: "V"
+        scale: 0.01
+        rule: 1
+        registers: [0x0076]
+        icon: mdi:battery
+        configurable:
+          min: 38
+          max: 61
+          step: 0.1
+        range:
+          min: 3800
+          max: 6100
+
+      - name: Battery Restart Voltage
+        update_interval: 300
+        class: "voltage"
+        state_class: measurement
+        uom: "V"
+        scale: 0.01
+        rule: 1
+        registers: [0x0077]
+        icon: mdi:battery
+        configurable:
+          min: 38
+          max: 61
+          step: 0.1
+        range:
+          min: 3800
+          max: 6100
+
+      - name: Battery Low Voltage
+        update_interval: 300
+        class: "voltage"
+        state_class: measurement
+        uom: "V"
+        scale: 0.01
+        rule: 1
+        registers: [0x0078]
+        icon: mdi:battery
+        configurable:
+          min: 38
+          max: 61
+          step: 0.1
+        range:
+          min: 3800
+          max: 6100
+
       - name: "Battery Grid Charging Current"
         update_interval: 300
         class: "current"
diff --git a/custom_components/solarman/inverter_definitions/deye_sg04lp3.yaml b/custom_components/solarman/inverter_definitions/deye_sg04lp3.yaml
index 90188197..2cdf2e79 100644
--- a/custom_components/solarman/inverter_definitions/deye_sg04lp3.yaml
+++ b/custom_components/solarman/inverter_definitions/deye_sg04lp3.yaml
@@ -380,6 +380,127 @@ parameters:
           - key: 0x0002
             value: No Battery
 
+      - name: Battery Resistance
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "mΩ"
+        scale: 1
+        rule: 1
+        registers: [0x0071]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 6000
+
+      - name: Battery Charging efficiency
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "%"
+        scale: 0.1
+        rule: 1
+        registers: [0x0072]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 100
+
+      - name: Battery Shutdown SOC
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "%"
+        scale: 1
+        rule: 1
+        registers: [0x0073]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 100
+
+      - name: Battery Restart SOC
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "%"
+        scale: 1
+        rule: 1
+        registers: [0x0074]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 100
+
+      - name: Battery Low SOC
+        update_interval: 300
+        class: ""
+        state_class: measurement
+        uom: "%"
+        scale: 1
+        rule: 1
+        registers: [0x0075]
+        icon: mdi:battery
+        configurable:
+        range:
+          min: 0
+          max: 100
+
+      - name: Battery Shutdown Voltage
+        update_interval: 300
+        class: "voltage"
+        state_class: measurement
+        uom: "V"
+        scale: 0.01
+        rule: 1
+        registers: [0x0076]
+        icon: mdi:battery
+        configurable:
+          min: 38
+          max: 61
+          step: 0.1
+        range:
+          min: 3800
+          max: 6100
+
+      - name: Battery Restart Voltage
+        update_interval: 300
+        class: "voltage"
+        state_class: measurement
+        uom: "V"
+        scale: 0.01
+        rule: 1
+        registers: [0x0077]
+        icon: mdi:battery
+        configurable:
+          min: 38
+          max: 61
+          step: 0.1
+        range:
+          min: 3800
+          max: 6100
+
+      - name: Battery Low Voltage
+        update_interval: 300
+        class: "voltage"
+        state_class: measurement
+        uom: "V"
+        scale: 0.01
+        rule: 1
+        registers: [0x0078]
+        icon: mdi:battery
+        configurable:
+          min: 38
+          max: 61
+          step: 0.1
+        range:
+          min: 3800
+          max: 6100
+
       - name: "Battery Grid Charging Current"
         update_interval: 300
         class: "current"