From d78b0eb3acf69f4adb7ae1d1bf18b066adbf2090 Mon Sep 17 00:00:00 2001 From: An Phi Date: Sat, 13 Nov 2021 20:49:48 -0500 Subject: [PATCH] improve sass building workflow and optimize bot script (#665) * update PR template * revamp sass dev and build workflow * move github bot/automation to its own package * bump dependencies * add changeset * exclude bot package from checks --- .changeset/chilly-olives-drum.md | 23 ++++++ .changeset/good-snails-collect.md | 20 +++++ .github/PULL_REQUEST_TEMPLATE.md | 2 + .github/workflows/bot-new-issue-label.yml | 8 +- CONTRIBUTING.md | 35 +++------ package.json | 9 ++- .../legend-application/_package.config.js | 9 --- packages/legend-application/package.json | 4 +- packages/legend-art/_package.config.js | 9 --- packages/legend-art/package.json | 4 +- packages/legend-dev-utils/CopyrightUtils.js | 51 +----------- packages/legend-dev-utils/DevUtils.js | 5 ++ .../_package.config.js | 9 --- .../package.json | 4 +- .../_package.config.js | 9 --- .../legend-extension-dsl-diagram/package.json | 4 +- .../_package.config.js | 9 --- .../package.json | 4 +- .../_package.config.js | 9 --- .../legend-extension-dsl-text/package.json | 4 +- .../_package.config.js | 9 --- .../_package.config.js | 9 --- packages/legend-graph/_package.config.js | 9 --- packages/legend-query-app/_package.config.js | 9 --- packages/legend-query-app/package.json | 4 +- packages/legend-query-deployment/package.json | 2 +- packages/legend-query/_package.config.js | 9 --- packages/legend-query/package.json | 4 +- .../legend-server-depot/_package.config.js | 9 --- .../legend-server-sdlc/_package.config.js | 9 --- packages/legend-studio-app/_package.config.js | 9 --- packages/legend-studio-app/package.json | 4 +- .../legend-studio-deployment/package.json | 2 +- .../_package.config.js | 9 --- .../package.json | 4 +- .../_package.config.js | 9 --- .../package.json | 2 +- packages/legend-studio/_package.config.js | 9 --- packages/legend-studio/package.json | 4 +- .../addBundledCodeCopyrightHeader.js | 49 ------------ scripts/github-bot/README.md | 11 +++ .../{workflow => github-bot}/labelNewIssue.js | 0 scripts/github-bot/package.json | 17 ++++ scripts/github-bot/yarn.lock | 2 + scripts/release/preparePublishContent.js | 16 +--- scripts/workflow/buildSass.js | 75 ++++++++++++++++++ scripts/workflow/devSassAll.js | 77 +++++++++++++++++++ yarn.lock | 23 ++++-- 48 files changed, 302 insertions(+), 324 deletions(-) create mode 100644 .changeset/chilly-olives-drum.md create mode 100644 .changeset/good-snails-collect.md delete mode 100644 scripts/copyright/addBundledCodeCopyrightHeader.js create mode 100644 scripts/github-bot/README.md rename scripts/{workflow => github-bot}/labelNewIssue.js (100%) create mode 100644 scripts/github-bot/package.json create mode 100644 scripts/github-bot/yarn.lock create mode 100644 scripts/workflow/buildSass.js create mode 100644 scripts/workflow/devSassAll.js diff --git a/.changeset/chilly-olives-drum.md b/.changeset/chilly-olives-drum.md new file mode 100644 index 0000000000..937c1ccf4a --- /dev/null +++ b/.changeset/chilly-olives-drum.md @@ -0,0 +1,23 @@ +--- +'@finos/legend-application': patch +'@finos/legend-art': patch +'@finos/legend-dev-utils': patch +'@finos/legend-extension-dsl-data-space': patch +'@finos/legend-extension-dsl-diagram': patch +'@finos/legend-extension-dsl-serializer': patch +'@finos/legend-extension-dsl-text': patch +'@finos/legend-extension-external-format-json-schema': patch +'@finos/legend-extension-external-store-service': patch +'@finos/legend-graph': patch +'@finos/legend-query': patch +'@finos/legend-query-app': patch +'@finos/legend-query-deployment': patch +'@finos/legend-server-depot': patch +'@finos/legend-server-sdlc': patch +'@finos/legend-studio': patch +'@finos/legend-studio-app': patch +'@finos/legend-studio-deployment': patch +'@finos/legend-studio-extension-management-toolkit': patch +'@finos/legend-studio-extension-query-builder': patch +'@finos/legend-github-bot': patch +--- diff --git a/.changeset/good-snails-collect.md b/.changeset/good-snails-collect.md new file mode 100644 index 0000000000..41a3b279a5 --- /dev/null +++ b/.changeset/good-snails-collect.md @@ -0,0 +1,20 @@ +--- +'@finos/legend-application': patch +'@finos/legend-art': patch +'@finos/legend-dev-utils': patch +'@finos/legend-extension-dsl-data-space': patch +'@finos/legend-extension-dsl-diagram': patch +'@finos/legend-extension-dsl-serializer': patch +'@finos/legend-extension-dsl-text': patch +'@finos/legend-extension-external-format-json-schema': patch +'@finos/legend-extension-external-store-service': patch +'@finos/legend-graph': patch +'@finos/legend-query': patch +'@finos/legend-query-app': patch +'@finos/legend-server-depot': patch +'@finos/legend-server-sdlc': patch +'@finos/legend-studio': patch +'@finos/legend-studio-app': patch +'@finos/legend-studio-extension-management-toolkit': patch +'@finos/legend-studio-extension-query-builder': patch +--- diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7347d924ea..6d54102b4c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -23,6 +23,8 @@ ## How did you test this change? - [ ] Test(s) added +- [ ] Manual testing (please provide screenshots/recordings) +- [ ] No testing (please provide an explanation)