diff --git a/src/common.rs b/src/common.rs index 5e6977a..3f05b2b 100644 --- a/src/common.rs +++ b/src/common.rs @@ -258,7 +258,7 @@ fn remap_dictionary_key_nulls( values: ArrayRef, ) -> DataFusionResult> { // fast path: no nulls in values - if values.null_count() == 0{ + if values.null_count() == 0 { return Ok(DictionaryArray::new(keys, values)); } diff --git a/tests/main.rs b/tests/main.rs index fb6015a..0019e1e 100644 --- a/tests/main.rs +++ b/tests/main.rs @@ -1280,11 +1280,13 @@ async fn test_dict_haystack() { assert_batches_eq!(expected, &batches); } - fn check_for_null_dictionary_values(array: &dyn Array) { let array = array.as_any().downcast_ref::>().unwrap(); let keys_array = array.keys(); - let keys = keys_array.iter().filter_map(|x| x.map(|v| usize::try_from(v).unwrap())).collect::>(); + let keys = keys_array + .iter() + .filter_map(|x| x.map(|v| usize::try_from(v).unwrap())) + .collect::>(); let values_array = array.values(); // no non-null keys should point to a null value for i in 0..values_array.len() { @@ -1330,20 +1332,8 @@ async fn test_dict_get_no_null_values() { let sql = "select json_get_str(x, 'baz') v from data"; let expected = [ - "+------+", - "| v |", - "+------+", - "| |", - "| fizz |", - "| |", - "| abcd |", - "| |", - "| fizz |", - "| fizz |", - "| fizz |", - "| fizz |", - "| |", - "+------+", + "+------+", "| v |", "+------+", "| |", "| fizz |", "| |", "| abcd |", "| |", "| fizz |", + "| fizz |", "| fizz |", "| fizz |", "| |", "+------+", ]; let batches = ctx.sql(&sql).await.unwrap().collect().await.unwrap(); assert_batches_eq!(expected, &batches);