Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Support linting of git-hosted notebook tasks on jobs #2922

Closed
2 of 3 tasks
asnare opened this issue Oct 10, 2024 · 1 comment
Closed
2 of 3 tasks

[FEATURE]: Support linting of git-hosted notebook tasks on jobs #2922

asnare opened this issue Oct 10, 2024 · 1 comment
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@asnare
Copy link
Contributor

asnare commented Oct 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

When a job task should run a notebook, the notebook_task.source indicates whether the path is a workspace path or should be located via the git-source configured in the job settings.

Currently we always treat the path on a notebook task as a workspace paths, which fails if it's a path relative to the git-source.

Proposed Solution

Additional Context

One of the downstream errors that we currently see is attempts to download workspace paths without a leading slash (/). (Such relative paths are invalid workspace paths.)

Here is where we (currently) do not distinguish between workspace and git-source paths. (Fixed in #2924.)

@asnare asnare added enhancement New feature or request needs-triage labels Oct 10, 2024
@asnare asnare added this to UCX Oct 10, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Oct 10, 2024
@nfx nfx added invalid This doesn't seem right and removed needs-triage labels Oct 11, 2024
@nfx
Copy link
Collaborator

nfx commented Oct 11, 2024

we do support linting git repos with lint-local-code command. git integration works the way that only the owner of the git token can access the repo and no the administrator.

@nfx nfx closed this as completed Oct 11, 2024
@github-project-automation github-project-automation bot moved this from Triage to Archive in UCX Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
Archived in project
Development

No branches or pull requests

2 participants