Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict numpy dependency #88

Open
bjgbeelen opened this issue Feb 10, 2023 · 5 comments
Open

Strict numpy dependency #88

bjgbeelen opened this issue Feb 10, 2023 · 5 comments

Comments

@bjgbeelen
Copy link

Hi!

I'm running into an issue that this package requires a very specific numpy package 1.23.4. Aside from wondering why it needs numpy in the first place (I didn't dive into that), I'm wondering if this needs to be this specific.

Context:
We are using NixPkgs to provide reproducible environments. I'm trying to compile the latest dbt-databricks version and this is a dependency. From the latest stable NixPkgs I get numpy version 1.23.3. I can override it but building this specific version of numpy myself is quite heavy. And it makes me wonder if it can be solved in a different way by relaxing the constraint :-)

Thanks for thinking along!

@betodealmeida
Copy link

Same here, I'm having problems updating the Databricks driver in Apache Superset because of this. Can we relax the versioning here?

numpy = [
{version = "1.21.1", python = ">=3.7,<3.8"},
{version = "1.23.4", python = ">=3.8"}
]

@susodapop
Copy link
Contributor

There's a PR for this here: #74 we're working on merging it ASAP.

@susodapop
Copy link
Contributor

Also @betodealmeida we'd like to improve the Superset experience which currently doesn't use our built-in SQLAlchemy dialect (just released in v2.4.0). Are you interested in helping us test the new version?

@betodealmeida
Copy link

Also @betodealmeida we'd like to improve the Superset experience which currently doesn't use our built-in SQLAlchemy dialect (just released in v2.4.0). Are you interested in helping us test the new version?

Yeah, I'm happy to bump the version and test it! Will do it this weekend.

@susodapop
Copy link
Contributor

@betodealmeida Unfortunately that won't work! Superset needs to be configured to use our in-built dialect. At present if you just bump the version of databricks-sql-connector nothing will change. Once we have concrete steps for testing I'll ping you here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants