Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display human readable error if metasrv started without --single or --join #5407

Closed
drmingdrmer opened this issue May 16, 2022 · 4 comments · Fixed by #5443
Closed

Display human readable error if metasrv started without --single or --join #5407

drmingdrmer opened this issue May 16, 2022 · 4 comments · Fixed by #5443
Assignees
@Xuanwo
Labels
A-meta Area: databend meta serive good first issue Category: good first issue

Comments

@drmingdrmer
Copy link
Member

Summary
@drmingdrmer drmingdrmer added A-meta Area: databend meta serive good first issue Category: good first issue labels May 16, 2022
@BohuTANG
Copy link
Member

Databend config needs a friendly hint for the user if it doesn't work, @Xuanwo may have(plan) some ideas on it.

@Xuanwo
Copy link
Member

Xuanwo commented May 16, 2022

Yep, I'm working on implementing #5297. After this PR, we will be able to do some bigger changes to our config handler. In which we can:

  • Print deprecated messages if needed
  • Print helpful messages for humans as this issue mentioned.
  • Give kindful guidance for the frequent mistake.

@Xuanwo
Copy link
Member

Xuanwo commented May 18, 2022

@drmingdrmer If we must choose one of --single and --join, how about taking --single as default?

@Xuanwo Xuanwo mentioned this issue May 18, 2022
Merged
@Xuanwo Xuanwo self-assigned this May 18, 2022
@drmingdrmer
Copy link
Member Author

@drmingdrmer If we must choose one of --single and --join, how about taking --single as default?

Sounds great!

@Xuanwo Xuanwo mentioned this issue May 18, 2022
Closed
@Xuanwo Xuanwo moved this to 📋 Backlog in Xuanwo's Work Sep 15, 2022
@Xuanwo Xuanwo moved this from 📋 Backlog to 📦 Done in Xuanwo's Work Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xuanwo Xuanwo

Labels
A-meta Area: databend meta serive good first issue Category: good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(metasrv): Display friendly error if not started with valid flags Xuanwo/databend
3 participants
@drmingdrmer @BohuTANG @Xuanwo