-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing with CuPy 9 #190
Comments
Are there CI services that will let us test with GPU? Or are you suggesting that we try and do some local testing? I can merge #157 if you like. The stable release of cupy 9.0.0 is scheduled for April 2021, so I wasn't sure if it'd be confusing for people if that wasn't out yet. |
Not really no. I think testing locally would make the most sense We don't need to rush things. Though making sure those changes work with the current CuPy would be good. What happens if a user has an older version of CuPy installed and those functions are not present? |
You get an error. I can't remember off the top of my head whether you have to wait until executing the task graph to find out about the problem or not. |
I went to do this today, but I'm having a lot of trouble getting CUDA & cupy set up correctly. Would you maybe be able to help with that @jakirkham ? (Maybe email or whereby is a better format for that discussion, rather than here though) |
Yep happy to help. Feel free to propose a time and we can go from there |
@jakirkham has nvidia open sourced its CI code/bots? I know you guys have CI testing integrated with github using your own machines. If you could make it easy for projects to set up their own CI on their own boxes, that might help adoption and testing throughout the ecosystem. Not to mention sell some extra GPUs on top. ;) Personally I have zero experience setting up something like that. |
Emailed you a link re: scheduling @jakirkham |
There should be a Conda package built with CuPy 9b3 with CUDA 11.2 support shortly (~1hr). Assuming
|
Just tried it now & all the cupy tests we have pass locally on my machine with
|
I'm going to close this issue (we have now tested dask-image locally with cupy version 9 and it all looks ok on the main branch). Annoyingly, the tests I wrote for #157 are failing. That's an unmerged branch, so I'm going to add more details over there since that will need to be resolved before merging. |
Thanks for doing that Genevieve! 😄 Glad you were able to test that out locally 🙂 |
dask/community#138 - Ben says:
|
Currently CuPy is doing pre-releases for 9. Both prebuilt wheels and Conda packages exist. It would be good to try things out with the pre-releases and make sure things are looking ok.
Should add a lot of functionality has been filled out in
cupyx.scipy.ndimage
. So it might be worth checking if this unlocks anything that we were blocked on here previously. For example morphological operations ( #157 ) come to mindcc @grlee77 (for awareness)
The text was updated successfully, but these errors were encountered: