Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableSelfCollision has a misleading argument #702

Closed
mkoval opened this issue Apr 25, 2016 · 1 comment
Closed

enableSelfCollision has a misleading argument #702

mkoval opened this issue Apr 25, 2016 · 1 comment
Assignees
Milestone

Comments

@mkoval
Copy link
Collaborator

mkoval commented Apr 25, 2016

enableSelfCollision takes a _enableAdjacentBodyCheck boolean argument. This leads to the unintuitive behavior that this line actually enables self-collision checking:

skeleton->enableSelfCollision(false);

It also leads to a strange asymmetry, where there is no way to change the value of isEnabledAdjacentBodyCheck without also enabling self-collision detection. I suggest deprecating enableSelfCollision and replacing it with two separate functions: one for enabling/disabling self collision checks and one for enabling/disabling adjacent body checks.

@jslee02
Copy link
Member

jslee02 commented May 9, 2016

Resolved by #718

@jslee02 jslee02 closed this as completed May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants