Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DART exposes its COVERALLS_REPO_TOKEN on Travis #687

Closed
mkoval opened this issue Apr 22, 2016 · 0 comments · Fixed by #688
Closed

DART exposes its COVERALLS_REPO_TOKEN on Travis #687

mkoval opened this issue Apr 22, 2016 · 0 comments · Fixed by #688
Assignees
@jslee02
Labels
status: in-progress
Milestone
DART 6.0.0

Comments

@mkoval
Copy link
Collaborator

mkoval commented Apr 22, 2016

The coveralls repository token is supposed to be private because it grants write access. DART sets COVERALLS_REPO_TOKEN in its .travis.yml file, which is public. I suggest:

  1. removing COVERALLS_REPO_TOKEN from .travis.yml
  2. generating a new repository token for coveralls
  3. set COVERALLS_REPO_TOKEN to the new token on Travis as a hidden environment variable

This is what I did in personalrobotics/aikido#25 and it works great!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jslee02 jslee02

Labels
status: in-progress
Projects
None yet
Milestone
DART 6.0.0
Development

Successfully merging a pull request may close this issue.

Remove coveralls token from .travis.yml dartsim/dart
2 participants
@mkoval @jslee02