Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect linear acceleration function code #305

Closed
mxgrey opened this issue Jan 20, 2015 · 1 comment
Closed

Incorrect linear acceleration function code #305

mxgrey opened this issue Jan 20, 2015 · 1 comment
Milestone

Comments

@mxgrey
Copy link
Member

mxgrey commented Jan 20, 2015

I noticed that this acceleration function has the same source code as this velocity function. This is most likely a copy/paste error.

This version of the function does not get tested in testDynamics (instead, the no-argument version is tested), which is probably how this has gone unnoticed. For now, it's probably sufficient to just change each mV in the function to mA. The upcoming code where I created the Frame class already has tests for all of its different position, velocity, and acceleration functions, so we shouldn't have to worry about writing new tests to catch this stuff.

@mxgrey
Copy link
Member Author

mxgrey commented Feb 24, 2015

Fixed by #319

@mxgrey mxgrey closed this as completed Feb 24, 2015
@jslee02 jslee02 added this to the Release DART 5.0 milestone Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants