Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing FindEIGEN3.cmake #1053

Closed
mxgrey opened this issue Apr 16, 2018 · 3 comments
Closed

Consider removing FindEIGEN3.cmake #1053

mxgrey opened this issue Apr 16, 2018 · 3 comments
Assignees

Comments

@mxgrey
Copy link
Member

mxgrey commented Apr 16, 2018

I recently discovered that Eigen3 provides an Eigen3Config.cmake file. We should consider using this instead of having our own find-module for Eigen.

But one thing to watch out for is it seems that the imported target that gets mentioned in the documentation is not available in Eigen version 3.2.92 (the documentation is for 3.3.4), so we might want to avoid using the imported target in order to keep supporting older setups.

@mxgrey mxgrey added this to the DART 7.0.0 milestone Apr 16, 2018
@mxgrey mxgrey self-assigned this Apr 16, 2018
@jslee02
Copy link
Member

jslee02 commented Apr 16, 2018

One caveat would be that Eigen3Config.cmake is not provided for some Eigen versions that DART supports (>= 3.2.0). We could work around this by using config mode first and then module mode if it fails to find Eigen.

@mxgrey
Copy link
Member Author

mxgrey commented Apr 16, 2018

That makes sense if we want to keep supporting older versions of Eigen.

That would also give us the liberty to create imported targets for older versions of Eigen that don't automatically provide imported targets.

@jslee02
Copy link
Member

jslee02 commented Apr 29, 2019

I believe this is resolved by #1212

@jslee02 jslee02 closed this as completed Apr 29, 2019
@jslee02 jslee02 removed this from the DART 7.0.0 milestone Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants