From bc78a374005cf3a3ef52b081f27d19ed4b278ddf Mon Sep 17 00:00:00 2001 From: "Addisu Z. Taddese" Date: Sat, 18 Dec 2021 09:40:44 -0600 Subject: [PATCH] Address reviewer feedback. Signed-off-by: Addisu Z. Taddese --- dart/collision/CollisionGroup.hpp | 8 ++++---- unittests/unit/test_CollisionGroups.cpp | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dart/collision/CollisionGroup.hpp b/dart/collision/CollisionGroup.hpp index 4fb867200a1f2..61e964bbf2cfc 100644 --- a/dart/collision/CollisionGroup.hpp +++ b/dart/collision/CollisionGroup.hpp @@ -218,18 +218,18 @@ class CollisionGroup /// template. void unsubscribeFrom(); - // Check if this is subscribed to bodyNode and the other sources + /// Check if this is subscribed to bodyNode and the other sources template bool isSubscribedTo( const dynamics::BodyNode* bodyNode, const Others*... others); - // Check if this is subscribed to skeleton and the other sources + /// Check if this is subscribed to skeleton and the other sources template bool isSubscribedTo( const dynamics::Skeleton* skeleton, const Others*... others); - // Return true. This function is for terminating the recursive variadic - // template + /// Return true. This function is for terminating the recursive variadic + /// template bool isSubscribedTo(); /// Return true if this CollisionGroup contains shapeFrame diff --git a/unittests/unit/test_CollisionGroups.cpp b/unittests/unit/test_CollisionGroups.cpp index fec70f6699aef..855cb21d6c22c 100644 --- a/unittests/unit/test_CollisionGroups.cpp +++ b/unittests/unit/test_CollisionGroups.cpp @@ -312,7 +312,7 @@ TEST_P(CollisionGroupsTest, RemovedSkeletonSubscription) boxShape); // Needed to update subscribtions - world->step(1); + world->step(); EXPECT_TRUE(group->hasShapeFrame(sn)); const auto* skel_A_ptr = skel_A.get(); @@ -322,7 +322,7 @@ TEST_P(CollisionGroupsTest, RemovedSkeletonSubscription) world->removeSkeleton(skel_A); world->removeSkeleton(skel_B); - world->step(1); + world->step(); EXPECT_FALSE(group->hasShapeFrame(sn)); EXPECT_FALSE(group->isSubscribedTo(skel_A_ptr));