Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure http/browser_client.dart in http package to avoid dart:mirrors usage (?) #21917

Closed
DartBot opened this issue Dec 18, 2014 · 4 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Dec 18, 2014

This issue was originally filed by @Scorpiion


I'm not sure how much job is needed, but because of the new "dart2js mirrors policy" with the huge warning, it feels like it might be worth considering.

Is it a good idea (or even possible) to make so that the browser client don't depend on dart:mirrors? Or are users recommended to not use the http package on the client for a foreseeable future? (assuming most people would want to follow the instructions and try to avoid the dart2js warning)

Regards, Robert

@DartBot
Copy link
Author

DartBot commented Dec 18, 2014

This comment was originally written by @Scorpiion


To be clear, a simple Hello World app importing package:http/browser_client.dart gives this:

* Your app imports dart:mirrors via:

  • main.dart => package:http => dart:mirrors

@lrhn
Copy link
Member

lrhn commented Dec 19, 2014

Removed Type-Defect label.
Added Type-Enhancement, Pkg-Http, Area-Pkg, Triaged labels.

@nex3
Copy link
Member

nex3 commented Dec 19, 2014

The warning sucks, but in practice the usage of mirrors in the http package is harmless. It's only used to determine that dart:io is unavailable, and adds essentially no size overhead to the compiled output.

I'd love to remove mirrors from the package, but right now the language just doesn't support it while maintaining the same API.


Marked this as being blocked by #6943.

@DartBot DartBot added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Dec 19, 2014
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/http#25.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants