Strict index builder timeout + exceptions are not catched. #8525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Feb 3, 2025
- A safeguard to wait at least an hour before crashing the VM, just in case we have a crash loop.
- Note: this only has a top-level timeout, we could add lower-level timeouts, but the top-level catch-all should also be updated to rethrow either way.
d1ef1f7 to
93c3d5c
Compare
sigurdm
reviewed
Feb 18, 2025
app/lib/search/backend.dart
Outdated
| _logger.warning('Snapshot update failed.', e, st); | ||
| _logger.pubNoticeShout( | ||
| 'snapshot-building', 'Snapshot update failed.', e, st); | ||
| // Force waiting at least an hour before we rethrow the exception |
There was a problem hiding this comment.
Is this to avoid too quick cycling of restarts? Could you explain that in this comment?
sigurdm
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.