Add timeout option to package:cronet_http

[techouse]

Hi,

Are there any plans to add a timeout option to package:cronet_http?

I'm not sure if a timeout option was omitted by design or by mistake.

The source code seems to say it's disabled by design

@Override
public void setConnectTimeout(int timeout) {
    // Per-request connect timeout is not supported because of late binding.
    // Sockets are assigned to requests according to request priorities
    // when sockets are connected. This requires requests with the same host,
    // domain and port to have same timeout.
    Log.d(TAG, "setConnectTimeout is not supported by CronetHttpURLConnection");
}

[brianquinlan]

Can you use the timeout method on the future returned by the client?

[techouse]

Well, I could, however, that kinda breaks the "plug & play" rationale as it involves additional application logic outside the Client. I was hoping for a timeout error to be thrown from the send method

http/pkgs/cronet_http/lib/src/cronet_client.dart

Line 326 in ec73b19

Future<StreamedResponse> send(BaseRequest request) async {

I could make a PR if that's the route this should take. Otherwise I'll simply defer migrating from IOClient to Cronet on Android.

[brianquinlan]

@techouse I don't think that we should add timeout capabilities for a single client.

See #21

[techouse]

@techouse I don't think that we should add timeout capabilities for a single client.

@brianquinlan Hmm, I'm not sure I follow as both cupertino_http and HttpClient have a timeout option, just cronet_http is missing it.

• cupertino_http: https://pub.dev/documentation/cupertino_http/latest/cupertino_http/URLSessionConfiguration/timeoutIntervalForRequest.html
• http_client: https://api.flutter.dev/flutter/dart-io/HttpClient/connectionTimeout.html

I've taken your initial suggestion of adding a Future.timeout lejard-h/chopper#604

[brianquinlan]

Hey @techouse ,

I thought that you were looking for a per-request timeout.

timeoutIntervalForRequest can be used to configure the timeout for all requests made by the Client
connectionTimeout is per-Client and it also only applies to the connection phase of the request - the response can take an arbitrary amount of time.

[absar]

Hi @brianquinlan ,
Does it mean there is no cronet equivalent of cupertino_http.timeoutIntervalForRequest?
Adding a timeout to client future does not seem appropriate, since it's not going to cancel the request after timeout, secondly the timeout on future will essentially be for the whole response duration e.g. client.get as opposed to just request/connection timeout.

@techouse i think your original request is still valid, this ticket should not be closed?