From 7896e11d8bf19342c6deaae170f4f208a114000c Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 23 Sep 2024 17:33:06 +0200 Subject: [PATCH 1/5] Update health.dart --- pkgs/firehose/lib/src/health/health.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/firehose/lib/src/health/health.dart b/pkgs/firehose/lib/src/health/health.dart index 12e1d1f7..042abd5a 100644 --- a/pkgs/firehose/lib/src/health/health.dart +++ b/pkgs/firehose/lib/src/health/health.dart @@ -166,6 +166,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati ...['pub', 'global', 'run'], 'dart_apitool:main', 'diff', + '--no-check-sdk-version', ...['--old', baseRelativePath], ...['--new', relativePath], ...['--report-format', 'json'], From b73d4744376dd2406d1ebb8d03a25bcbb9397f32 Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 23 Sep 2024 11:49:21 -0400 Subject: [PATCH 2/5] Add changelog --- pkgs/firehose/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/firehose/CHANGELOG.md b/pkgs/firehose/CHANGELOG.md index 1ded817f..fa424963 100644 --- a/pkgs/firehose/CHANGELOG.md +++ b/pkgs/firehose/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.9.3 + +- Do not check Dart SDK in PR Health breaking check. + ## 0.9.2 - Improve formatting of the github workflow summary comments so they use less From 5a2e79c257b0f8f3dc898436d0ee030f85ddbb6e Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 23 Sep 2024 11:49:28 -0400 Subject: [PATCH 3/5] Fix analysis error --- pkgs/corpus/lib/api.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/corpus/lib/api.dart b/pkgs/corpus/lib/api.dart index 258d49fd..2f6880f7 100644 --- a/pkgs/corpus/lib/api.dart +++ b/pkgs/corpus/lib/api.dart @@ -180,7 +180,7 @@ class ApiUseCollector extends RecursiveAstVisitor implements SurveyorVisitor { return; } - var enclosingElement = element.enclosingElement!; + var enclosingElement = element.enclosingElement3!; if (enclosingElement.kind == ElementKind.CLASS) { final name = enclosingElement.name!; From 31b52b1ab953104f16dfa0cdcc124789cb7cfcde Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 23 Sep 2024 11:50:44 -0400 Subject: [PATCH 4/5] Rev firehose version --- pkgs/firehose/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/firehose/pubspec.yaml b/pkgs/firehose/pubspec.yaml index 73403073..2b83244f 100644 --- a/pkgs/firehose/pubspec.yaml +++ b/pkgs/firehose/pubspec.yaml @@ -1,6 +1,6 @@ name: firehose description: A tool to automate publishing of Pub packages from GitHub actions. -version: 0.9.2 +version: 0.9.3 repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose environment: From 3bb409cdae5420946105009075e4bae19551fbac Mon Sep 17 00:00:00 2001 From: Moritz Date: Mon, 23 Sep 2024 11:53:05 -0400 Subject: [PATCH 5/5] Do not fix after all --- pkgs/corpus/lib/api.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/corpus/lib/api.dart b/pkgs/corpus/lib/api.dart index 2f6880f7..333696dc 100644 --- a/pkgs/corpus/lib/api.dart +++ b/pkgs/corpus/lib/api.dart @@ -180,7 +180,9 @@ class ApiUseCollector extends RecursiveAstVisitor implements SurveyorVisitor { return; } - var enclosingElement = element.enclosingElement3!; + //TODO: fix as soon as enclosingElement3 is on Dart stable + // ignore: deprecated_member_use + var enclosingElement = element.enclosingElement!; if (enclosingElement.kind == ElementKind.CLASS) { final name = enclosingElement.name!;