You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
isoos opened this issue
Nov 26, 2024
· 3 comments
· Fixed by #3940
Labels
P1A high priority bug; for example, a single project is unusable or has many test failurestype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)
The documentation URLs for libraries generated by 8.3.0 are missing an ending slash. When hosted, this breaks the sidebar and all relative links, as the base-uri reference is one directory up.
To fix that, the hosting needs to redirect from /library-x to /library-x/, and that is one extra request (extra latency) that could have been spared with the ending slash.
Related note: The change of the library URLs (#3895) is breaking pub.dev in multiple ways. We should explore how we could define a somewhat future-proof way to prevent or mitigate such disruptions. (We should also prevent situations where we need the beta SDK to analyze or generate sources for packages requiring the same beta SDK, but that's another discussion.)
The text was updated successfully, but these errors were encountered:
I tested the new URLs only with serving the HTML files on disk via the dhttpd package, which I think behaves like vanilla Apache, and loads /index.html if it is available. But I guess this is not universal behavior. We can instead link to library-x/.
srawlins
added
type-bug
Incorrect behavior (everything from a crash to more subtle misbehavior)
P1
A high priority bug; for example, a single project is unusable or has many test failures
labels
Dec 3, 2024
And if the browser requested the URL without the ending slash and the webserver served the index.html without redirecting, it breaks the relative links and the sidebar loading, as they are one-level off (verified while adopting this to pub-dev).
P1A high priority bug; for example, a single project is unusable or has many test failurestype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)
The documentation URLs for libraries generated by 8.3.0 are missing an ending slash. When hosted, this breaks the sidebar and all relative links, as the base-uri reference is one directory up.
To fix that, the hosting needs to redirect from
/library-x
to/library-x/
, and that is one extra request (extra latency) that could have been spared with the ending slash.Related note: The change of the library URLs (#3895) is breaking pub.dev in multiple ways. We should explore how we could define a somewhat future-proof way to prevent or mitigate such disruptions. (We should also prevent situations where we need the beta SDK to analyze or generate sources for packages requiring the same beta SDK, but that's another discussion.)
The text was updated successfully, but these errors were encountered: