-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small name changes #378
Comments
The Not sure what |
Ok, at the time I wrote this I didn't understand that I agree with |
Also do some clean-up. Fixes #21, #22 and #24: * https://github.com/dart-lang/characters/issues/24 * https://github.com/dart-lang/characters/issues/22 * https://github.com/dart-lang/characters/issues/21
Add some extra functionality Also do some clean-up. Fixes #21, #22 and #24: * https://github.com/dart-lang/characters/issues/24 * https://github.com/dart-lang/characters/issues/22 * https://github.com/dart-lang/characters/issues/21
Add some extra functionality Also do some clean-up. Fixes dart-lang/characters#21, dart-lang/characters#22 and dart-lang/characters#24: * https://github.com/dart-lang/characters/issues/24 * https://github.com/dart-lang/characters/issues/22 * https://github.com/dart-lang/characters/issues/21
iteratorAtEnd
is really confusing. It should be calledreverseIterator
oriteratorReversed
.A lot of methods have their parameters called
other
. I would prefer to call themsequence
. For example:bool startsWith(Characters sequence)
instead ofbool startsWith(Characters other)
Of course, this is a matter of taste, so feel free to disagree.
The text was updated successfully, but these errors were encountered: