Skip to content
This repository has been archived by the owner on Mar 27, 2020. It is now read-only.

Create a branch for enabling http tests #4

Closed
donny-dont opened this issue Jun 22, 2017 · 4 comments
Closed

Create a branch for enabling http tests #4

donny-dont opened this issue Jun 22, 2017 · 4 comments

Comments

@donny-dont
Copy link

Currently there is a circular dependency between test and http caused by package_resolver. Pub no longer allows a package to depend on itself so dependency_overrides cannot be used to successfully install test within the 0.12.0-dev version of http.

Please create a branch with the following changes so it can be used as an override within http until the dependency here can be loosened.

diff --git a/pubspec.yaml b/pubspec.yaml
index 05454ee..654b6c9 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -9,7 +9,7 @@ environment:

 dependencies:
   collection: '^1.9.0'
-  http: '^0.11.0'
+  http: '^0.12.0-dev'
   package_config: '>=0.1.0 <2.0.0'
   path: '^1.0.0'
 dev_dependencies:
@donny-dont donny-dont changed the title Create a branch for enabling http tests Create a branch for enabling http tests Jun 22, 2017
@nex3
Copy link
Contributor

nex3 commented Jun 22, 2017

This looks like #1443, which I thought had been fixed.

@donny-dont, can you open a PR for this branch of package_resolver for now?

@donny-dont
Copy link
Author

I swore at one point that you COULD do this but it seems like pub changed to disallow that. Anyways I'll open up a branch on that.

@nex3
Copy link
Contributor

nex3 commented Jun 22, 2017

Actually, I just re-tested, and it looks like this works:

dependency_overrides:
  package_resolver: '^1.0.0'

@donny-dont
Copy link
Author

@nex3 weird I see that it works as well. Preparing some tests for you to land. I'll do it like that.

@nex3 nex3 closed this as completed Jun 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants