Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Integration of Support for "Playnite Sounds Mod" Audio Controls #47

Open
sunsetHue opened this issue Jun 3, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@sunsetHue
Copy link

Feature Description

The Playnite Sounds Mod extension maintained by ashpynov documents theme support for music controls in the README that is not present from testing of the Stardust theme.

Submitting this feature request to confirm if there are plans to support it.

Screenshots

No response

@sunsetHue sunsetHue added the enhancement New feature or request label Jun 3, 2024
@sunsetHue sunsetHue changed the title [FEATURE REQUEST] Integration of Support for "Playnite Sounds Mod" Audio Controls [Feature Request] Integration of Support for "Playnite Sounds Mod" Audio Controls Jun 3, 2024
@darklinkpower
Copy link
Owner

Just wondering, why was that made a separate extension if it's a fork? That comes with many issues and I'm not sure about adding functionality for a fork rather than the original plugin.

Tagging @ashpynov

@sunsetHue
Copy link
Author

The core reason I opened this request is that ashpynov appears to be actively developing this plugin with public releases but the status of the main plugin is unclear.

The original add-on functions but appears to otherwise not be in ongoing development. The last merge was done in November 2022 and was the PR of a second contributor with merge permission (cnapolit). joyrider3774's last personal contribution appears closer to two years. cnapolit apparently maintains his own private fork that received updates until January 2024 but does not have any compiled public releases.

Tagging @cnapolit. Best to keep this on-hold until and unless either replies.

@ashpynov
Copy link

ashpynov commented Jun 8, 2024

The main goal is to have legacy '2 years code' brings to live, while @cnapolit continuing his global refactoring. As soon as he will complete - it will be time to merge my changes on 'ideas' level to original branch.
99% of functionality Mod does without theme assistant. So only if you will want to show current song name - it will provide endpoint - otherwise it does not make any sence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants