Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapr annotate command #870

Closed
jjcollinge opened this issue Jan 12, 2022 · 5 comments · Fixed by #873
Closed

dapr annotate command #870

jjcollinge opened this issue Jan 12, 2022 · 5 comments · Fixed by #873
Assignees
Labels
area/cli size/M 2 weeks of work triaged/resolved The issue has been triaged
Milestone

Comments

@jjcollinge
Copy link
Contributor

jjcollinge commented Jan 12, 2022

Describe the proposal

Caveat that this is very much inspired by linkerd inject but I think it'd be useful to also have a dapr inject command that injects the annotations on to a Kubernetes deployment manifest for you. The manifest can be read from stdin (so it can be piped kubectl get deploy -o yaml | dapr inject | kubectl apply -f -, read from disk dapr inject <dir> | kubectl apply -f - or fetched from a remote URI dapr inject http://example.com/deploy.yml | kubectl apply -f -. In order to write the annotations the command will need to have all the different configurations options available as flags.

This could in theory be extended to do the full sidecar injection too as an alternative to using the sidecar injector. This might be useful for users who want to fully vet artifacts before deployment.

For more details, please see the attached PR #873

Release Note

RELEASE NOTE: ADD Dapr inject CLI command.

@mukundansundar
Copy link
Collaborator

@yaron2 Please add your thoughts on this ...

@yaron2 yaron2 added this to the v1.7 milestone Jan 28, 2022
@yaron2
Copy link
Member

yaron2 commented Jan 28, 2022

I approve this, triaging to 1.7. Left a question on the PR itself.

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Feb 27, 2022
@jjcollinge
Copy link
Contributor Author

/no-stale

@dapr-bot dapr-bot removed the stale label Feb 27, 2022
@mukundansundar mukundansundar added area/cli size/M 2 weeks of work triaged/resolved The issue has been triaged labels Mar 3, 2022
@mukundansundar mukundansundar modified the milestones: v1.7, v1.8 Mar 16, 2022
@jjcollinge jjcollinge changed the title dapr inject command dapr annotate command Mar 20, 2022
@jjcollinge
Copy link
Contributor Author

dapr inject moved to dapr annotate as it's a more accurate term for what this command is doing. In the future we may consider adding a dapr inject that builds on this command to perform a full sidecar injection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli size/M 2 weeks of work triaged/resolved The issue has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants