Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSD Sqlite not accepted #211

Closed
matbgn opened this issue Jun 8, 2024 · 2 comments · Fixed by #215
Closed

RSD Sqlite not accepted #211

matbgn opened this issue Jun 8, 2024 · 2 comments · Fixed by #215
Labels
kind/bug Something isn't working

Comments

@matbgn
Copy link

matbgn commented Jun 8, 2024

Describe the bug
RSD Sqlite extension is not tolerated

Error: : invalid sqlite file extension

To Reproduce
Steps to reproduce the behavior:

dblab --db ~/Data.rsd --driver sqlite

Expected behavior
Accept .rsd as valid .sqlite alternative

OS (please complete the following information):

  • Ubuntu 22.04 64bit / Linux 6.5.0-35-generic
  • Version dblab : 0.24.0
@matbgn matbgn added the kind/bug Something isn't working label Jun 8, 2024
@danvergara
Copy link
Owner

danvergara commented Jun 11, 2024

@matbgn I made a PR (#215) to address this issue. I removed all validation on sqlite file extensions, since it can be any, sqlite will figure out if the file is valid.

Please, QA the PR to make sure it works as expected.

@matbgn
Copy link
Author

matbgn commented Jun 16, 2024

I just tried your branch and it works! Thanks

@matbgn matbgn closed this as completed Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants