Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common result between node callback and promise style #28

Open
nevercast opened this issue Jul 26, 2015 · 2 comments
Open

Common result between node callback and promise style #28

nevercast opened this issue Jul 26, 2015 · 2 comments

Comments

@nevercast
Copy link

Currently the callback style only returns an alive boolean,

where the promise resolves with an object containing formally the host and alive, but now also includes the result string as of #23

Would you be open to making the result consistent between the two implementations? If we are changing the callback style result from a boolean to an object it would be a good time to consider an (err, result) callback signature as changing the result type is an API breaking change anyway.

I can write the implementation for this, but a major version increment will be needed.

@mondwan
Copy link
Collaborator

mondwan commented Apr 20, 2016

I guess this is possible. However, it may break backward compatibility. What do you think? @danielzzz @dougluce

@dougluce
Copy link
Collaborator

Im definitely for this one, with a major version change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants