You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the callback style only returns an alive boolean,
where the promise resolves with an object containing formally the host and alive, but now also includes the result string as of #23
Would you be open to making the result consistent between the two implementations? If we are changing the callback style result from a boolean to an object it would be a good time to consider an (err, result) callback signature as changing the result type is an API breaking change anyway.
I can write the implementation for this, but a major version increment will be needed.
The text was updated successfully, but these errors were encountered:
Currently the callback style only returns an alive boolean,
where the promise resolves with an object containing formally the host and alive, but now also includes the result string as of #23
Would you be open to making the result consistent between the two implementations? If we are changing the callback style result from a boolean to an object it would be a good time to consider an (err, result) callback signature as changing the result type is an API breaking change anyway.
I can write the implementation for this, but a major version increment will be needed.
The text was updated successfully, but these errors were encountered: