Remove signup form when signup is disabled

[Chartreusito]

I was surprised that disabling signup using the SIGNUPS_ALLOWED=false does not disable the signup form.

Is there any technical reason behind it ? I know the form throws an error signifying signup is disabled, but i expected that this form would be disabled as a security measure when signup is disabled.

[BlackDex]

The technical reason was that it wasn't possible. But it will be soon.

[Chartreusito]

Thanks for the heads-up and for your work :)

[tessus]

Just out of curiosity, how would someone who got an invite from an admin, even though SIGNUPS_ALLOWED=false is set, register then?

[BlackDex]

The links still work, and you can still navigate manually to it, but the link to the signup will not be visible.
It will not help against knowledgeable users though.
But then still, they will be blocked since the server checks this too anyway.

It's just a cosmetic thing, nothing more.

[stefan0xC]

Only the link on the start page will be hidden via CSS:

vaultwarden/src/static/templates/scss/vaultwarden.scss.hbs

Lines 95 to 101 in c0be36a

	{{#if signup_disabled}}
	/* Hide the register link on the login screen */
	app-login form div + div + div + div + hr,
	app-login form div + div + div + div + hr + p {
	@extend %vw-hide;
	}
	{{/if}}

So the form itself would still be available.

[tessus]

thx @BlackDex and @stefan0xC