Latest release unhides DangerDeps product causing failures

[AvdLee]

This is the error I'm getting:

Swift package target 'Danger' is linked as a static library by 'WeTransferPRLinterTests' and 'Danger', but cannot be built dynamically because there is a package product with the same name.

Using Xcode 13. The plugin is open-source, so you can try it out:
https://github.com/WeTransfer/WeTransfer-iOS-CI/tree/master/WeTransferPRLinter

This is currently how the Package.swift looks:

// swift-tools-version:5.5
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
    name: "WeTransferPRLinter",
    products: [
        .library(
            name: "WeTransferPRLinter",
            targets: ["WeTransferPRLinter"]
        )
    ],
    dependencies: [
        .package(url: "https://github.com/danger/swift", .exact("3.10.2")),
        .package(name: "DangerSwiftCoverage", url: "https://github.com/f-meloni/danger-swift-coverage", from: "1.1.0"),
        .package(name: "DangerXCodeSummary", url: "https://github.com/f-meloni/danger-swift-xcodesummary", from: "1.2.1"),
        .package(name: "Files", url: "https://github.com/JohnSundell/Files", from: "4.1.1")
    ],
    targets: [
        .target(
            name: "WeTransferPRLinter",
            dependencies: [
                .product(name: "Danger", package: "swift"),
                "DangerSwiftCoverage",
                "DangerXCodeSummary",
                "Files"
            ]
        ),
        .testTarget(
            name: "WeTransferPRLinterTests",
            dependencies: [
                "WeTransferPRLinter",
                .product(name: "DangerFixtures", package: "swift")
            ]
        )
    ]
)

Commenting out the test target lets Xcode build successfully.

[AvdLee]

@f-meloni I feel like many of my problems have been starting with this line not being commented out in the .12 release tag:
https://github.com/danger/swift/blob/3.12.0/Package.swift#L12

[AvdLee]

Confirmed, finally got everything working again. The above line should be commented out, right?

I've created my own fork which makes my Danger work again. I can even run it locally on an M1 machine. In other words, this would solve:

• danger-swift not running with swift 5.5 on xcode 13 beta #449 (comment)
• Danger was created for incompatible target arm64-apple-macosx10.10 #464 (comment)

As I'm building using Xcode 13 and Swift 5.5 on a M1 MacBook

To be clear; I tried using:

.library(name: "DangerDeps[PACKAGE_NAME]", type: .dynamic, targets: ["DangerDependencies"]),

Instead of:

.library(name: "DangerDeps", type: .dynamic, targets: ["DangerDependencies"]),

But I couldn't get that to work in anyway

Updated the title of this issue!

[417-72KI]

According to the old tags,

.library(name: "DangerDeps", type: .dynamic, targets: ["DangerDependencies"]),

should be commented out on release, as @AvdLee said.

https://github.com/danger/swift/blob/3.11.0/Package.swift
https://github.com/danger/swift/blob/3.10.0/Package.swift

[f-meloni]

Thank you very much for investigating this!
#477 should solve the issue, and then I can make a new release.

[f-meloni]

According to the old tags,

.library(name: "DangerDeps", type: .dynamic, targets: ["DangerDependencies"]),

should be commented out on release, as @AvdLee said.

https://github.com/danger/swift/blob/3.11.0/Package.swift https://github.com/danger/swift/blob/3.10.0/Package.swift

Yes, just realised that I've missed this change on #414

[f-meloni]

I've just released 3.12.1 ac99660
let me know how it goes

[AvdLee]

@f-meloni confirmed that release fixed all my issues. Closing this one. Thanks for the quick turnaround!

[f-meloni]

Amazing! Thank you for all the help!

[AvdLee]

@f-meloni reopening this issue for the original issue description; I'm still getting this error for my plugin:

Swift package target 'Danger' is linked as a static library by 'WeTransferPRLinterTests' and 'Danger', but cannot be built dynamically because there is a package product with the same name.

Don't you have the same for your plugins once you update it to Swift 5.5?

[AvdLee]

Interesting enough it seems fixable by removing the .dynamic type from the package.swift:

I'm not sure how this affects regular Danger usage though

[f-meloni]

If I remember correctly we need to link Danger when we compile the Dangerfile
https://github.com/danger/swift/blob/master/Sources/RunnerLib/SPMDanger.swift#L48
https://github.com/danger/swift/blob/master/Sources/Runner/Commands/Runner.swift#L108

And dynamic is to force SPM to create a library we can link.

Don't you have the same for your plugins once you update it to Swift 5.5?

🤔 Let me give it a try

[AvdLee]

And dynamic is to force SPM to create a library we can link.

Back in the days .dynamic was needed due to SPM not correctly supporting static linking IIRC. I wouldn't be surprised if this is fixed in Swift 5.5, so it's worth a try! Either way, the current setup does seem to break plugin testing 🤔

[f-meloni]

@AvdLee from my very first test, everything looks ok f-meloni/danger-swift-coverage#31.

[AvdLee]

@f-meloni posted my feedback inside the PR you opened!