-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Create arm64 binary for Homebrew #1282
Comments
I admit I’m not entirely sure I understand. Do we pre-build DangerJS binaries? (Why?) Can’t they be built on the end-user’s system, using their local processor architecture? |
Danger-Swift in Homebrew requires Danger-JS as dependency, and it seems to install pre-built binary. I'm not familiar with npm, and don't know how to build binary from npm package even if there are other ways to install😔 |
Happy to have someone move the build infra into github actions and making it builds both binaries, right now it's effort enough to boot up an old mac to even make the x86 ones |
This comment was marked as spam.
This comment was marked as spam.
Resolved by #1342 ! |
danger-js binaries installed via Homebrew are built in x86_64 architecture.
It causes danger/swift#464.
We need arm64 binary for M1 macs.
The text was updated successfully, but these errors were encountered: