Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoice interaction with text/mentions/note links/multi-invoice #213

Closed
olheadinternet opened this issue Jan 2, 2023 · 1 comment
Closed
Labels
bug Something is not working, or not working as intended

Comments

@olheadinternet
Copy link
Contributor

proposal: if there are invoice/invoices - that’s all that should be rendered as preview. hyperlinks and note links should only appear as text in the body only.

Related to other proposal I've made that if one or more links or note links appear, there simply shouldn’t be any preview rendered.
Hyperlinks (disappear from body of text): #212
note link interaction with invoice: #193
note links (bug/enhancement): #169

i don't have a great idea for what happens when there is text between two invoices... i like the carousel, but maybe render two invoices when note is expanded so the text corresponds to the invoice.


bellow is examples of many different interactions with invoices in damus version 1.0.0 (1)


here is an example of how text following a invoice appears

note1gpqmm9sudm7eedwn88vgntwxn8460zx27cussxc8kqj2wj78skyqugq70t

IMG_0398


here is an example of how note links following a invoice appears

note1la7790kwaq9n37weuvqu6uuaezq0yy55ep7z53cuxpud9f5xe3wq0pcwna

IMG_0399


here is an example of how 2 invoices appear

note1kad84quec7v03nxqcdc8yn2453edn3gemn820rfetld0dmjtgkhq8q4t5u

IMG_0400


here is an example of text between 2 invoices appear

note17mvx0l3h765pjlcpge8c5egkrwh5sh7t5tytjt94kxn3q26uzylsrhk737

IMG_0401


Here is an example of link and an invoice

note1plzttzlgm4ecmkajd5xc7m6eudukh9lluu6wpmw4uulm6kpa9xpqexjpsj

IMG_0403

@bebopkid bebopkid added the bug Something is not working, or not working as intended label Jan 3, 2023
@jb55
Copy link
Collaborator

jb55 commented May 6, 2024

almost noone uses invoices anymore sadly

@jb55 jb55 closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working, or not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants