support for notification-arns in qaz

[jtuller]

It would be nice to be able to set the notification arns for cloudformation create / update events. with the aws cli it's as easy as specifying some ARNs behind the --notification-arns like so:

https://docs.aws.amazon.com/cli/latest/reference/cloudformation/create-stack.html

--notification-arns (list)

The Simple Notification Service (SNS) topic ARNs to publish stack related events. You can find your SNS topic ARNs using the SNS console or your Command Line Interface (CLI).
Syntax:

"string" "string" ...

Would you be open to this? I'm thinking it should be in the config.yml as a property of the stack, something like:

region: us-east-1
project: my-project

stacks:
 my-stack:
    source: ./cloud-formation.yml
    parameters:
      - ParamOne: some-value
      - ParamTwo: anotherValue
    notification-arns:
      - arn:aws:sns:us-east-1:123456789012:MyCloudFormationEventSNSTopic
      - arn:aws:sns:us-east-1:123456789012:MyOtherCloudFormationEventSNSTopic

If there is already support for this I did not notice it in the documentation.

[daidokoro]

Hey @jtuller ,

Thanks for this.

You're right, notification-arns aren't supported yet. I think you're recommendation to have it as a stack property fits the qaz workflow.

Happy to review a pull request or work on this myself. Let me know.

[jtuller]

Thanks @daidokoro - I will have a look, point me in the right direction and I'll see what I can do. I see where the parameters are getting picked up already, just need to see how to add them into the flow.
Fair warning I've never written a single line of Go... ;)

[daidokoro]

Hey @jtuller , created a pull request #39 adding the requested feature. You can run through the changes I made there to see how I did it, incase you want to make similar contributions in the future. I'll run some tests before merging it tomorrow.

Also, Go is a great language, definitely worth learning ;)

[jtuller]

hi @daidokoro - thanks for running with it - I didn't have much time to work on this last week. Once it gets merged, we will be using it right away, I'll let you know if we have any issues. Thanks again! :)