Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor idea: worker-api/impl #308

Closed
dai-shi opened this issue Dec 24, 2023 · 3 comments · Fixed by #324
Closed

refactor idea: worker-api/impl #308

dai-shi opened this issue Dec 24, 2023 · 3 comments · Fixed by #324

Comments

@dai-shi
Copy link
Owner

dai-shi commented Dec 24, 2023

I thought we needed to stream data through message port, but looking at
https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Transferable_objects
can we actually transfer ReadableStream. Does it work on Node too?
@himself65
Copy link
Contributor

yes, https://github.com/nodejs/node/blob/4d3923aabaa6d57dc9dc3c554434fa69410c3d55/benchmark/webstreams/js_transfer.js#L47

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 24, 2023

nice, it will simplify the code a bit.

@Aslemammad
Copy link
Contributor

working on this

@Aslemammad Aslemammad mentioned this issue Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(worker-api/impl): pass stream to parent Aslemammad/waku
3 participants
@dai-shi @himself65 @Aslemammad