Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URSA install issues #7

Open
mingard opened this issue Oct 2, 2017 · 6 comments
Open

URSA install issues #7

mingard opened this issue Oct 2, 2017 · 6 comments
Assignees

Comments

@mingard
Copy link
Contributor

mingard commented Oct 2, 2017

Errors are regularly thrown when installing an app, e.g. https://github.com/dadi/publish that utilised ssl. The package may need to be changed.

Node version: 8

@mingard mingard self-assigned this Oct 2, 2017
@anaumovets
Copy link

Details:
errors are as follows:

> ursa@0.9.4 install /home/anton/dev/DADI/test/node_modules/ursa
> node-gyp rebuild

make: Entering directory '/home/anton/dev/DADI/test/node_modules/ursa/build'
  CXX(target) Release/obj.target/ursaNative/src/ursaNative.o
../src/ursaNative.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE RsaWrap::OpenPublicSshKey(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/ursaNative.cc:389:13: error: invalid use of incomplete type ‘RSA {aka struct rsa_st}’
     obj->rsa->n = BN_bin2bn(data_n, n_length, NULL);
             ^~
In file included from /usr/include/openssl/crypto.h:31:0,
                 from /usr/include/openssl/bio.h:20,
                 from /usr/include/openssl/asn1.h:16,
                 from /usr/include/openssl/rsa.h:16,
                 from ../src/ursaNative.h:13,
                 from ../src/ursaNative.cc:3:

This is due to a known issue with breaking changes introduced by new version of OpenSSL (1.1.x):
https://stackoverflow.com/questions/40549318/error-invalid-use-of-incomplete-type-rsa-aka-struct-rsa-st-in-openssl-1-1

URSA github has a fix for this: JoshKaufman/ursa#167
but it's not published as a node module version yet (last version is 2 years old)

@danwdart
Copy link

v 0.10 should fix the node 10 issue and possibly others.

@mingard
Copy link
Contributor Author

mingard commented Oct 15, 2018

@danwdart v 0.10 of what?

@danwdart
Copy link

sorry I mean v0.10 of ursa (but then I was told it was going to be removed from here)

@mingard
Copy link
Contributor Author

mingard commented Oct 29, 2018

@danwdart I believe you are removing SSL support from Publish, not URSA from SSL. Please don't remove URSA from this module.

@danwdart
Copy link

Oh, I see. I wasn't going to do that, don't worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants