Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

Updated analysis: Experimental_strategy specific copy_consensus run #152

Closed
kgaonkar6 opened this issue Aug 9, 2021 · 8 comments
Closed
Assignees

Comments

@kgaonkar6
Copy link
Contributor

kgaonkar6 commented Aug 9, 2021

What analysis module should be updated and why?

copy_number_consensus_call currently uses all samples in the following CNV files which

cnv-cnvkit.seg.gz
cnv-controlfreec.tsv.gz
sv-manta.tsv.gz

But WGS and WXS samples need to be handled differently so the code will need update.

What changes need to be made? Please provide enough detail for another participant to make the update.

The options I see are:

  1. Logic inside the code to only use WGS samples in script that creates the Snakemake file and run the module to generate 2/3 cnv caller consensus calls. (I believe this is faster because it doesn't have to separate the input merged files to the WXS files in scratch)

  2. Logic to handle WGS and WXS separately with different Snakemake files as implemented by bix-ops that uses cnvkit_freec consensus calls however for OT it was decided to only use cnvkit calls for WXS ( This will help get the bixops and OT development on the same page though)

@jharenza @logstar @zhangb1 for input.

What input data should be used? Which data were used in the version being updated?

v7

cnv-cnvkit.seg.gz
cnv-controlfreec.tsv.gz
sv-manta.tsv.gz
histologies.tsv

When do you expect the revised analysis will be completed?

2 days

Who will complete the updated analysis?

@kgaonkar6

@kgaonkar6 kgaonkar6 changed the title Updated analysis: Data type specific copy_consensus run Updated analysis: Experimental_strategy specific copy_consensus run Aug 9, 2021
@jharenza
Copy link
Collaborator

jharenza commented Aug 9, 2021

Cc @yuankunzhu as well

@jharenza
Copy link
Collaborator

Note: filenames will also need to be updated

@jharenza
Copy link
Collaborator

@runjin326 can you work on part 1 as priority? then, I think @zhangb1 can use this code (part 2) in the toolkit.

@runjin326
Copy link

@jharenza, sure! I will prioritize this and I'll ping you and @zhangb1 when completed!

@runjin326
Copy link

@jharenza, hmm I am getting a bit confused right now. I think the code in this script already subset for WGS and only run for those? And I think the run script already called the right file (although the README.md does need an update)?
I also ran the code that generate the snakeMake and individual file , they all have 1276 samples which is as expected for all WGS + Tumor. Am I missing something here?

@jharenza
Copy link
Collaborator

Ahh, ok- I thought @kgaonkar6 did this for v7, but then saw the ticket - so maybe part 1 is complete.

@kgaonkar6
Copy link
Contributor Author

The code is run on v7 but since we didn't add any more WGS in v8 the files in the dev branch is up-to-date.

@runjin326 runjin326 mentioned this issue Aug 22, 2021
10 tasks
@runjin326
Copy link

Close with PR89

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants