Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth adjustment of breadthfirst layout can move nodes incorrectly #2009

Closed
maxkfranz opened this issue Oct 26, 2017 · 0 comments
Closed

Depth adjustment of breadthfirst layout can move nodes incorrectly #2009

maxkfranz opened this issue Oct 26, 2017 · 0 comments
Labels
bug A bug in the code of Cytoscape.js
Milestone
3.2.5

Comments

@maxkfranz
Copy link
Member

Issue type

Bug report

Environment info

  • Cytoscape.js version : 3.2.4
  • Browser/Node.js & version : Tested on Node 6.11.0 and Chrome 61 (Mac)

Current (buggy) behaviour

The depths can be incorrectly assigned to nodes due to how the arrays are spliced.

Desired behaviour

Assign depths without incorrect side-effects.

Fixed by PR #1992

Minimum steps to reproduce

See #1992
@maxkfranz maxkfranz added the bug A bug in the code of Cytoscape.js label Oct 26, 2017
@maxkfranz maxkfranz added this to the 3.2.5 milestone Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug in the code of Cytoscape.js
Projects
None yet
Milestone
3.2.5
Development

No branches or pull requests
1 participant
@maxkfranz