Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't invalidate the bounding box cache for nodes on position changes #1881

Closed
maxkfranz opened this issue Jul 4, 2017 · 0 comments
Closed

Don't invalidate the bounding box cache for nodes on position changes #1881

maxkfranz opened this issue Jul 4, 2017 · 0 comments
Labels
performance Improving speed and memory usage
Milestone
3.3.0

Comments

@maxkfranz
Copy link
Member

Instead of recalculating the bb all over again (expensive), just shift the bb by the position delta.
@maxkfranz maxkfranz added the performance Improving speed and memory usage label Jul 4, 2017
@maxkfranz maxkfranz added this to the future milestone Mar 5, 2018
@maxkfranz maxkfranz modified the milestones: future, 3.3.0 Jul 4, 2018
@maxkfranz maxkfranz mentioned this issue Jul 4, 2018
Closed
1 task
maxkfranz added a commit that referenced this issue Jul 4, 2018
@maxkfranz
Refactoring re. rendering performance -- bounding boxes, hashes, and …
0733599 
…texture cache invalidations

- N.b.: Some further minor changes for performance improvements are marked with "TODO"
- Don't require parallel edges iteration in `eles.boundingBox()` re. rendered style recalculation
- Shift the cached bounding box on node position changes -- rather than complete invalidation
- Simplify the rendering `notify()` function
- Simplify batching code
- Refactoring of control point calculations
- Simplify rendered style queuing to do traversals only on ticks
- Make the stylesheet more minimalistic
- Ensure that the element texture cache is not invalidated when the style hash is unchanged
- Style-originating triggers are organised per property

Ref: #1881 #2027 #2145 #1337
maxkfranz added a commit that referenced this issue Jul 9, 2018
@maxkfranz
Update the touch event handlers in the renderer for dragging nodes to…
84c870d 
… use `nodes.silentShift()`

Ref #1881
maxkfranz added a commit that referenced this issue Jul 9, 2018
@maxkfranz
Fixes compound bounding box not updating when child moved
8e3de21 
Ref #1881
maxkfranz added a commit that referenced this issue Aug 10, 2018
@maxkfranz
Fix node dragging in the gesture recogniser of the base renderer class
a5446d9 
- Child nodes would be dragged doubly by having them being `shift()`ed while also having them in the drag list.
- Revise the drag lists to use collections to avoid the creation of intermediate arrays.  This should give a minor performance improvement.  It also simplifies lookups.
- Miscellaneous cleanup.

Ref #1881
maxkfranz added a commit that referenced this issue Aug 10, 2018
@maxkfranz
Don't recursively apply shifts to children if the position delta on t…
2476db1 
…he parent is zero.

Ref #1881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Improving speed and memory usage
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
1 participant
@maxkfranz