From 79d5646893d035360bed1554a1e55d495ff407ea Mon Sep 17 00:00:00 2001 From: Max Franz Date: Mon, 23 Oct 2017 16:53:14 -0400 Subject: [PATCH] Can't use the usual reverse-order for splicing in depths of BFS layout on account of saving the indices #1992 --- src/extensions/layout/breadthfirst.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/extensions/layout/breadthfirst.js b/src/extensions/layout/breadthfirst.js index 026397c96c..8227a1349c 100644 --- a/src/extensions/layout/breadthfirst.js +++ b/src/extensions/layout/breadthfirst.js @@ -193,11 +193,12 @@ BreadthFirstLayout.prototype.run = function(){ for( let i = 0; i < depths.length; i++ ){ let eles = depths[ i ]; - for( let j = eles.length - 1; j >= 0; j-- ){ + for( let j = 0; j < eles.length; j++ ){ let ele = eles[ j ]; if( ele == null ){ eles.splice( j, 1 ); + j--; continue; }