Update alias UI (#2960) #3188
Merged
Update alias UI (#2960) #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #477
|
I will merge this in for @chrisbreiding Do not merge into |
|
@chrisbreiding Nevermind, we changed the base branch to be a new 3.2.0 branch, but @brian-mann still wants to review the actual feature implementation. |
|
@jennifer-shehane Why was this closed? Do we not want it released before 4.0? Does it still need review before being merged? It could be released in 3.3.0 |
|
@chrisbreiding PRs automatically close when you delete the branch that they were to be merged into. I wish GitHub would indicate this more clearly. It always just looks like a manual closing. |
laurinenas
pushed a commit
to laurinenas/cypress
that referenced
this pull request
Apr 28, 2019
* Update alias UI (cypress-io#2960) - Fixes cypress-io#477 * fix reporter fixture name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work from #2960 originally done on 4.0 based-branch